feat(renderer): add dynamic terminal resize support - #12
Merged
venice-dev[bot] merged 18 commits intoMar 20, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add ResizeObserver-based container resize detection with debounced recalculation of terminal dimensions from measured character cell size. Includes onResize callback for PTY/SIGWINCH notification and dispose() for cleanup. Add resize edge-case tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove CLAUDE.md, PLAN.md, and tasks.json from the branch as they are not needed for the resize feature delivery and were flagged in security review as non-runtime artifacts that could influence automation workflows.
Chris-Moller
force-pushed
the
agent/73047d31-b9aa-4262-9d19-24eac57184c8
branch
3 times, most recently
from
March 19, 2026 23:31
43c067a to
4f9d93c
Compare
- Add focused test for resize callback invocation semantics - Document callback-only PTY notification design in renderer.js - Out-of-scope metadata files (PLAN.md, tasks.json) already removed Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Chris-Moller
force-pushed
the
agent/73047d31-b9aa-4262-9d19-24eac57184c8
branch
from
March 19, 2026 23:31
4f9d93c to
98a19b4
Compare
- Wire renderer.onResize in demo integration layer for PTY notification - Add integration tests proving resize emits backend notification with cols/rows - Document onResize callback contract and failure behavior in renderer.js Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Chris-Moller
force-pushed
the
agent/73047d31-b9aa-4262-9d19-24eac57184c8
branch
2 times, most recently
from
March 19, 2026 23:57
dcfea6d to
e5dc4ca
Compare
- Wire onResize in demo with structured PTY message and CustomEvent dispatch - Add integration test exercising full _handleResize flow with SIGWINCH-equivalent notification - Verify no duplicate notification for unchanged dimensions Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Chris-Moller
force-pushed
the
agent/73047d31-b9aa-4262-9d19-24eac57184c8
branch
2 times, most recently
from
March 19, 2026 23:58
dfa35b2 to
788f864
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds dynamic terminal resize support to the terminal emulator, enabling real-time response to window/container resize events.
Changes
_measureCellSize): Measures character cell dimensions (width/height) by creating a hidden probe span with the terminal's font settings, enabling accurate cols/rows calculation from pixel dimensions._setupResizeObserver): Attaches aResizeObserverto the terminal container to detect size changes automatically._handleResize): Computes new cols/rows from container pixel size, callsterminal.resize(cols, rows)to update internal state, re-renders the terminal, and fires anonResizecallback for backend PTY notification (SIGWINCH equivalent).dispose): Disconnects the ResizeObserver and clears timers.Acceptance Criteria Met
terminal.resize(cols, rows)called with new dimensionsonResizecallback